Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I omitted writing the readme for the time being, as I wasn't sure if there were going to be any changes.
If the design is accepted as is I could write it up!
A minor note is that shader globals are still a bit broken in some areas, for example it is possible to specify new local subresources (e.g. a
GradiantTexture2D) in the shader global editor, which will not be saved anywhere. A broken reference to them will still be stored in the value field of the shader global. Currently, the generator just errors out in such a case, but it could be handled gracefully by explicitly ignoring such default values (although letting the user know that what they are trying to do doesn't work due to Godot might be more desirable).Empty names are also possible and we just ignore the global in that case.
GlobalShaderParameterSetdoes NOT work at runtime, meaning we can only return values that have been set via the property previously.